Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for evaluating keypoints #2776

Conversation

akshitpriyesh
Copy link
Contributor

@akshitpriyesh akshitpriyesh commented Mar 12, 2023

What changes are proposed in this pull request?

Extended keypoints support and metrics for evaluation.

How is this patch tested? If it is not, please explain why.

Tested on thousands of images.

Release Notes

Extended support for keypoints

Is this a user-facing change that should be mentioned in the release notes?

  • Yes

What areas of FiftyOne does this PR affect?

This will extend support for keypoints and its evaluation .The code changes are done only on keypoints function. This change is not interfering with other applications.

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@lanzhenw lanzhenw requested a review from brimoor March 17, 2023 17:29
@brimoor brimoor changed the title extended keypoints support and added missing metrics Adding support for evaluating keypoints Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +37.54 🎉

Comparison is base (6b78dc6) 61.87% compared to head (53044b8) 99.41%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2776       +/-   ##
============================================
+ Coverage    61.87%   99.41%   +37.54%     
============================================
  Files          259       22      -237     
  Lines        43528    11367    -32161     
  Branches       350        0      -350     
============================================
- Hits         26934    11301    -15633     
+ Misses       16594       66    -16528     
Flag Coverage Δ
app ?
python 99.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/unittests/dataset_tests.py 99.83% <100.00%> (+<0.01%) ⬆️

... and 237 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brimoor brimoor changed the base branch from develop to keypoints-eval April 25, 2023 03:10
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This will be included in the next release 🥇

@brimoor brimoor merged commit dc471e6 into voxel51:keypoints-eval Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants